Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SearchApi integration #13669

Conversation

SebastjanPrachovskij
Copy link
Contributor

When integrating into the Langflow repo, we noticed some issues with the integration, mainly with imports.

This PR fixes the imports and updates the documentation.

@baskaryan since you reviewed our last PR - #11023.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 21, 2023
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 6:22pm

@dosubot dosubot bot added Ɑ: agent Related to agents module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Nov 21, 2023
@SebastjanPrachovskij
Copy link
Contributor Author

@baskaryan , @eyurtsev , @hwchase17

Could you please take a look into this? This is a relatively small PR, but a pressing issue to us. Thanks

@@ -270,6 +270,12 @@ def __getattr__(name: str) -> Any:
_warn_on_import(name, replacement="langchain.utilities.GoldenQueryAPIWrapper")

return GoldenQueryAPIWrapper
elif name == "SearchApiAPIWrapper":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not add it here - we're trying not to add more things here

@hwchase17 hwchase17 changed the base branch from master to harrison/searchapi December 5, 2023 00:23
@hwchase17 hwchase17 merged commit 6e9e992 into langchain-ai:harrison/searchapi Dec 5, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: agent Related to agents module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants