(rfc) chat models #1424
Merged
(rfc) chat models #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agola11
reviewed
Mar 3, 2023
agola11
reviewed
Mar 3, 2023
agola11
reviewed
Mar 3, 2023
| """Get the default parameters for calling OpenAI API.""" | ||
| return self.model_kwargs | ||
|
|
||
| def _create_retry_decorator(self) -> Callable[[Any], Any]: |
There was a problem hiding this comment.
Would refactor this out so both OpenAI and OpenAIChat can use it, input can be client and max_retries
agola11
reviewed
Mar 3, 2023
agola11
reviewed
Mar 4, 2023
agola11
reviewed
Mar 4, 2023
zachschillaci27
pushed a commit
to zachschillaci27/langchain
that referenced
this pull request
Mar 8, 2023
Co-authored-by: Ankush Gola <ankush.gola@gmail.com>
| openai = ChatOpenAI(model_name="gpt-3.5-turbo") | ||
| """ | ||
|
|
||
| client: Any #: :meta private: |
There was a problem hiding this comment.
My linter is complaining that I am not specifying a value for client when instantiating this class. I assume the following would be OK?
client: Any = None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.