Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Add async methods to the AstraDB BaseStore #16872

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Feb 1, 2024

No description provided.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 1, 2024
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 10:52pm

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Feb 1, 2024
@cbornet cbornet force-pushed the async-astra-store branch 4 times, most recently from fb7264d to c6fdee5 Compare February 1, 2024 22:53
@cbornet cbornet marked this pull request as draft February 2, 2024 16:01
@cbornet cbornet marked this pull request as ready for review February 3, 2024 14:18
@dosubot dosubot bot added Ɑ: memory Related to memory module 🔌: chroma Primarily related to ChromaDB integrations labels Feb 3, 2024
@cbornet
Copy link
Collaborator Author

cbornet commented Feb 3, 2024

Ready for review.
cc @hemidactylus

@hemidactylus
Copy link
Contributor

LGTM, nice work!

@cbornet cbornet marked this pull request as draft February 12, 2024 14:48
Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's a merge conflict (sorry for slow review), otherwise lgtm!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 13, 2024
@cbornet cbornet marked this pull request as ready for review February 15, 2024 09:07
@cbornet
Copy link
Collaborator Author

cbornet commented Feb 15, 2024

Rebased and conflict solved.

@cbornet cbornet changed the title Add async methods to the AstraDB BaseStore community: Add async methods to the AstraDB BaseStore Feb 15, 2024
Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
@cbornet
Copy link
Collaborator Author

cbornet commented Feb 18, 2024

BTW tag is wrong. It shouldn't be chroma but astradb

@baskaryan baskaryan added 🔌: astradb Primarily related to AstraDB integrations and removed 🔌: chroma Primarily related to ChromaDB integrations labels Feb 19, 2024
@baskaryan baskaryan merged commit e92e961 into langchain-ai:master Feb 19, 2024
58 checks passed
@cbornet cbornet deleted the async-astra-store branch February 19, 2024 20:30
haydeniw pushed a commit to haydeniw/langchain that referenced this pull request Feb 27, 2024
…in-ai#16872)



---------

Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌: astradb Primarily related to AstraDB integrations 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: memory Related to memory module size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants