-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Add async methods to the AstraDB BaseStore #16872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Feb 1, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
Medium size change to existing code to handle new use-cases
label
Feb 1, 2024
cbornet
force-pushed
the
async-astra-store
branch
4 times, most recently
from
February 1, 2024 22:53
fb7264d
to
c6fdee5
Compare
cbornet
force-pushed
the
async-astra-store
branch
from
February 3, 2024 14:17
c6fdee5
to
6dd649e
Compare
dosubot
bot
added
Ɑ: memory
Related to memory module
🔌: chroma
Primarily related to ChromaDB integrations
labels
Feb 3, 2024
Ready for review. |
LGTM, nice work! |
baskaryan
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there's a merge conflict (sorry for slow review), otherwise lgtm!
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Feb 13, 2024
cbornet
force-pushed
the
async-astra-store
branch
from
February 15, 2024 09:06
6dd649e
to
67561df
Compare
cbornet
force-pushed
the
async-astra-store
branch
from
February 15, 2024 09:10
67561df
to
3689ade
Compare
Rebased and conflict solved. |
cbornet
changed the title
Add async methods to the AstraDB BaseStore
community: Add async methods to the AstraDB BaseStore
Feb 15, 2024
baskaryan
reviewed
Feb 15, 2024
Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
BTW tag is wrong. It shouldn't be |
baskaryan
added
🔌: astradb
Primarily related to AstraDB integrations
and removed
🔌: chroma
Primarily related to ChromaDB integrations
labels
Feb 19, 2024
1 task
haydeniw
pushed a commit
to haydeniw/langchain
that referenced
this pull request
Feb 27, 2024
…in-ai#16872) --------- Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔌: astradb
Primarily related to AstraDB integrations
🤖:improvement
Medium size change to existing code to handle new use-cases
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
Ɑ: memory
Related to memory module
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.