Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[patch]: Fix Milvus add texts when ids=None #17021

Merged
merged 2 commits into from
Feb 9, 2024
Merged

community[patch]: Fix Milvus add texts when ids=None #17021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb36119
Fix Milvus
jaelgu Feb 5, 2024
174c9be
Merge branch 'master' into fix-milvus
baskaryan Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libs/community/langchain_community/vectorstores/milvus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,9 @@ def add_texts(
# Grab end index
end = min(i + batch_size, total_count)
# Convert dict to list of lists batch for insertion
insert_list = [insert_dict[x][i:end] for x in self.fields]
insert_list = [
insert_dict[x][i:end] for x in self.fields if x in insert_dict
]
# Insert into the collection.
try:
res: Collection
Expand Down
Loading