community: Expose Anthropic Retry Logic #17069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:XS
notAlex2
changed the title
baskaryan
reviewed
Feb 6, 2024
| @@ -92,11 +95,13 @@ def validate_environment(cls, values: Dict) -> Dict: | |||
| base_url=values["anthropic_api_url"], | |||
| api_key=values["anthropic_api_key"].get_secret_value(), | |||
| timeout=values["default_request_timeout"], | |||
| max_retries=values["max_retries"], | |||
There was a problem hiding this comment.
believe anthropic.Anthropic() doesn't accept None for max_retries, should we give it same default as they do (2)?
There was a problem hiding this comment.
Agreed, looks None isn't valid here. Updated to match their implementation.
There was a problem hiding this comment.
What do you think @baskaryan ?
dosubot
bot
added
size:S
dosubot
bot
added
size:XS
baskaryan
approved these changes
Feb 12, 2024
dosubot
bot
added
the
lgtm
|
@baskaryan could you run those workflows one more time? 🙏 |
|
Merged from |
snsten
pushed a commit
to snsten/langchain
that referenced
this pull request
Feb 15, 2024
**Description:** Expose Anthropic's retry logic, so that `max_retries` can be configured via langchain. Anthropic's retry logic is implemented in their Python SDK here: https://github.com/anthropics/anthropic-sdk-python?tab=readme-ov-file#retries --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
haydeniw
pushed a commit
to haydeniw/langchain
that referenced
this pull request
Feb 27, 2024
**Description:** Expose Anthropic's retry logic, so that `max_retries` can be configured via langchain. Anthropic's retry logic is implemented in their Python SDK here: https://github.com/anthropics/anthropic-sdk-python?tab=readme-ov-file#retries --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Expose Anthropic's retry logic, so that
max_retriescan be configured via langchain. Anthropic's retry logic is implemented in their Python SDK here: https://github.com/anthropics/anthropic-sdk-python?tab=readme-ov-file#retries