[Langchain_Community]: OpenLLM Client Fixes + Added Timeout Parameter #17478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:S
|
cc @aarnphm |
aarnphm
approved these changes
Feb 18, 2024
4 tasks
haydeniw
pushed a commit
to haydeniw/langchain
that referenced
this pull request
Feb 27, 2024
…gchain-ai#17478) - OpenLLM was using outdated method to get the final text output from openllm client invocation which was raising the error. Therefore corrected that. - OpenLLM `_identifying_params` was getting the openllm's client configuration using outdated attributes which was raising error. - Updated the docstring for OpenLLM. - Added timeout parameter to be passed to underlying openllm client.
eyurtsev
pushed a commit
that referenced
this pull request
Apr 9, 2024
…20007) Same changes as this merged [PR](#17478) (#17478), but for the async client, as the same issues persist. - Replaced 'responses' attribute of OpenLLM's GenerationOutput schema to 'outputs'. reference: https://github.com/bentoml/OpenLLM/blob/66de54eae7e420a3740ddd77862fd7f7b7d8a222/openllm-core/src/openllm_core/_schemas.py#L135 - Added timeout parameter for the async client. --------- Co-authored-by: Seray Arslan <seray.arslan@knime.com>
junkeon
pushed a commit
to UpstageAI/langchain
that referenced
this pull request
Apr 16, 2024
…angchain-ai#20007) Same changes as this merged [PR](langchain-ai#17478) (langchain-ai#17478), but for the async client, as the same issues persist. - Replaced 'responses' attribute of OpenLLM's GenerationOutput schema to 'outputs'. reference: https://github.com/bentoml/OpenLLM/blob/66de54eae7e420a3740ddd77862fd7f7b7d8a222/openllm-core/src/openllm_core/_schemas.py#L135 - Added timeout parameter for the async client. --------- Co-authored-by: Seray Arslan <seray.arslan@knime.com>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…20007) Same changes as this merged [PR](#17478) (#17478), but for the async client, as the same issues persist. - Replaced 'responses' attribute of OpenLLM's GenerationOutput schema to 'outputs'. reference: https://github.com/bentoml/OpenLLM/blob/66de54eae7e420a3740ddd77862fd7f7b7d8a222/openllm-core/src/openllm_core/_schemas.py#L135 - Added timeout parameter for the async client. --------- Co-authored-by: Seray Arslan <seray.arslan@knime.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_identifying_paramswas getting the openllm's client configuration using outdated attributes which was raising error.