community: add fixes for AzureSearch after update to stable azure-search-documents library #17599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kristapratico
commented
Feb 15, 2024
kristapratico
commented
- Description: Addresses the bugs described in linked issue where an import was erroneously removed and the rename of a keyword argument was missed when migrating from beta --> stable of the azure-search-documents package
- Issue: regressions with AzureSearch vectorstore update to v11.4.0 #17598
- Dependencies: N/A
- Twitter handle: N/A
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: vector store
|
Thanks - this looks great, appreciated |
mattgotteiner
approved these changes
Feb 15, 2024
|
Failing test in CI seems unrelated - it's also failing on other open PRs. |
|
I’m going to add a test after this is merged |
baskaryan
approved these changes
Feb 16, 2024
dosubot
bot
added
the
lgtm
4 tasks
haydeniw
pushed a commit
to haydeniw/langchain
that referenced
this pull request
Feb 27, 2024
…ure-search-documents library (langchain-ai#17599) - **Description:** Addresses the bugs described in linked issue where an import was erroneously removed and the rename of a keyword argument was missed when migrating from beta --> stable of the azure-search-documents package - **Issue:** langchain-ai#17598 - **Dependencies:** N/A - **Twitter handle:** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.