-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix bug that caused the word "Deprecated" to appear twice in doc-strings #17615
Merged
eyurtsev
merged 3 commits into
langchain-ai:master
from
leo-gan:docs-duplicate-deprecate-fix
Feb 16, 2024
Merged
docs: Fix bug that caused the word "Deprecated" to appear twice in doc-strings #17615
eyurtsev
merged 3 commits into
langchain-ai:master
from
leo-gan:docs-duplicate-deprecate-fix
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
eyurtsev
reviewed
Feb 16, 2024
eyurtsev
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just minor change for the comment
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Feb 16, 2024
eyurtsev
changed the title
docs: Depricate duplication bug
docs: Fix bug that caused the word "Deprecated" to appear twice in doc-strings
Feb 16, 2024
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Feb 16, 2024
dosubot
bot
added
Ɑ: agent
Related to agents module
🤖:bug
Related to a bug, vulnerability, unexpected error with an existing feature
labels
Feb 16, 2024
leo-gan
added
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
and removed
Ɑ: agent
Related to agents module
labels
Feb 16, 2024
eyurtsev
approved these changes
Feb 16, 2024
@eyurtsev Thanks! |
eyurtsev
pushed a commit
that referenced
this pull request
Feb 19, 2024
…ngs (#17704) The current issue: Several beta descriptions in the API Reference are duplicated. For example: `[Beta] Get a context value.[Beta] Get a context value.` for the [ContextGet class](https://api.python.langchain.com/en/latest/core_api_reference.html#module-langchain_core.beta) description. NOTE: I've tested it only with a new ut! I cannot build API Reference locally :( This PR related to #17615
haydeniw
pushed a commit
to haydeniw/langchain
that referenced
this pull request
Feb 27, 2024
…c-strings (langchain-ai#17615) The current issue: Most of the deprecation descriptions are duplicated. For example: `[Deprecated] Chat Agent.[Deprecated] Chat Agent.` for the [ChatAgent class](https://api.python.langchain.com/en/latest/langchain_api_reference.html#classes) description. NOTE: I've tested it only with new ut! I cannot build API Reference locally :(
haydeniw
pushed a commit
to haydeniw/langchain
that referenced
this pull request
Feb 27, 2024
…ngs (langchain-ai#17704) The current issue: Several beta descriptions in the API Reference are duplicated. For example: `[Beta] Get a context value.[Beta] Get a context value.` for the [ContextGet class](https://api.python.langchain.com/en/latest/core_api_reference.html#module-langchain_core.beta) description. NOTE: I've tested it only with a new ut! I cannot build API Reference locally :( This PR related to langchain-ai#17615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:bug
Related to a bug, vulnerability, unexpected error with an existing feature
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current issue:
Most of the deprecation descriptions in the API Reference are duplicated. For example:
[Deprecated] Chat Agent.[Deprecated] Chat Agent.
for the ChatAgent class description.NOTE: I've tested it only with new ut! I cannot build API Reference locally :(