-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Voyage AI updates default model and batch size #17655
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0ff1332
Change model to a required argument
fodizoltan be7d6cc
Removed the model attribute declaration as it isn't use
fodizoltan 146f0f1
Referring to the documentation
fodizoltan 4de3553
- model:str
fodizoltan 6e53bf9
Merge pull request #3 from voyage-ai/voyage_2_model
thomas0809 2275b99
Reformatting voyage
fodizoltan 1041892
Merge pull request #4 from voyage-ai/voyage_2_model
thomas0809 af41f94
Correct validator and log a warning if no model is defined
fodizoltan 0d3ae1a
Add test for handling the default value and small code correction
fodizoltan 6a789d3
Add test for handling the default value and small code correction
fodizoltan 59efab5
Corrections, due to comments (and more)
fodizoltan 5617a10
Corrections
fodizoltan 2b9a1d7
Merge branch 'langchain-ai:master' into master
thomas0809 853293c
Merge pull request #5 from voyage-ai/voyage_2_model
thomas0809 9eddafd
Update truncation default value
thomas0809 9d59a2f
Update argument type for lint
thomas0809 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change we probably don't want to make
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we may want to make a breaking change here. We want the user to specify the model when using the embeddings, as we want to encourage them to use the new models but we can't frequently update the default model here.
Do you have any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would recommend at least giving folks a month or two heads up before doing this by adding a warning for now that the breaking change will happen by a certain date. here's an example: #14614
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and for now update all of the documentation to show the latest models being passed in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that giving a warning could be a better idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the default value to
validate_environment
. Thus it should be backward compatible now.