Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mongo index creation #17748

Merged
merged 7 commits into from
Mar 9, 2024
Merged

Mongo index creation #17748

merged 7 commits into from
Mar 9, 2024

Conversation

nvenkat94
Copy link
Contributor

  • Title: Mongodb: MongoDB connection performance improvement.
  • Message:
    • Description: I made collection index_creation as optional. Index Creation is one time process.
    • Issue: MongoDBChatMessageHistory class object is attempting to create an index during connection, causing each request to take longer than usual. This should be optional with a parameter.
    • Dependencies: N/A
    • Branch to be checked: origin/mongo_index_creation

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 19, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 8, 2024 10:25pm

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Feb 19, 2024
baskaryan
baskaryan reviewed Feb 19, 2024
View reviewed changes
libs/community/langchain_community/chat_message_histories/mongodb.py
"""
Conditional Index Creation for collection
"""
self.collection.create_index("SessionId")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you ever want to specify index_name as well? if so could there be one paramter

index_name: Optional[str] = "SessionID"

and if index_name is None then you skip index creation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the 'index_name' parameter is not necessary at the moment. However, we currently use 'SessionID' in three other places. If provided, users can modify the key name as they wish. If you wish add index_name parameter, I can do it.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 8, 2024
@baskaryan baskaryan merged commit 7a18b63 into langchain-ai:master Mar 9, 2024
59 checks passed
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
@nvenkat94 @baskaryan
community[patch]: Mongo index creation (langchain-ai#17748)
86cf665 
- [ ] Title: Mongodb: MongoDB connection performance improvement. 
- [ ] Message: 
- **Description:** I made collection index_creation as optional. Index
Creation is one time process.
- **Issue:** MongoDBChatMessageHistory class object is attempting to
create an index during connection, causing each request to take longer
than usual. This should be optional with a parameter.
    - **Dependencies:** N/A
    - **Branch to be checked:** origin/mongo_index_creation

---------

Co-authored-by: Bagatur <baskaryan@gmail.com>
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@nvenkat94 @baskaryan @gkorland
community[patch]: Mongo index creation (langchain-ai#17748)
eba8982 
- [ ] Title: Mongodb: MongoDB connection performance improvement. 
- [ ] Message: 
- **Description:** I made collection index_creation as optional. Index
Creation is one time process.
- **Issue:** MongoDBChatMessageHistory class object is attempting to
create an index during connection, causing each request to take longer
than usual. This should be optional with a parameter.
    - **Dependencies:** N/A
    - **Branch to be checked:** origin/mongo_index_creation

---------

Co-authored-by: Bagatur <baskaryan@gmail.com>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@nvenkat94 @baskaryan @hinthornw
community[patch]: Mongo index creation (#17748)
00e999f 
- [ ] Title: Mongodb: MongoDB connection performance improvement. 
- [ ] Message: 
- **Description:** I made collection index_creation as optional. Index
Creation is one time process.
- **Issue:** MongoDBChatMessageHistory class object is attempting to
create an index during connection, causing each request to take longer
than usual. This should be optional with a parameter.
    - **Dependencies:** N/A
    - **Branch to be checked:** origin/mongo_index_creation

---------

Co-authored-by: Bagatur <baskaryan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan approved these changes

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nvenkat94 @baskaryan