commnity: refactor code for faiss vectorstore, update faiss vectorstore documentation #18092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
Ɑ: vector store
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
2b8593b
to
1eb5d60
Compare
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
1eb5d60
to
9ab3366
Compare
timofeyantonenko
force-pushed
the
faiss-improvements
branch
2 times, most recently
from
3ebe91e
to
0277555
Compare
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
0277555
to
07decd2
Compare
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
07decd2
to
ea2a57f
Compare
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
ea2a57f
to
7590512
Compare
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
7590512
to
50d0988
Compare
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
50d0988
to
4a6d347
Compare
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
4a6d347
to
6690a50
Compare
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
6690a50
to
f1165b9
Compare
baskaryan
approved these changes
Mar 1, 2024
dosubot
bot
added
the
lgtm
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
f1165b9
to
e171588
Compare
…ctor and delete in faiss vectorscore
timofeyantonenko
force-pushed
the
faiss-improvements
branch
from
e171588
to
0527df5
Compare
bechbd
pushed a commit
to bechbd/langchain
that referenced
this pull request
Mar 29, 2024
…ctorstore documentation (langchain-ai#18092) **Description:** Refactor code of FAISS vectorcstore and update the related documentation. Details: - replace `.format()` with f-strings for strings formatting; - refactor definition of a filtering function to make code more readable and more flexible; - slightly improve efficiency of `max_marginal_relevance_search_with_score_by_vector` method by removing unnecessary looping over the same elements; - slightly improve efficiency of `delete` method by using set data structure for checking if the element was already deleted; **Issue:** fix small inconsistency in the documentation (the old example was incorrect and unappliable to faiss vectorstore) **Dependencies:** basic langchain-community dependencies and `faiss` (for CPU or for GPU) **Twitter handle:** antonenkodev
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…ctorstore documentation (langchain-ai#18092) **Description:** Refactor code of FAISS vectorcstore and update the related documentation. Details: - replace `.format()` with f-strings for strings formatting; - refactor definition of a filtering function to make code more readable and more flexible; - slightly improve efficiency of `max_marginal_relevance_search_with_score_by_vector` method by removing unnecessary looping over the same elements; - slightly improve efficiency of `delete` method by using set data structure for checking if the element was already deleted; **Issue:** fix small inconsistency in the documentation (the old example was incorrect and unappliable to faiss vectorstore) **Dependencies:** basic langchain-community dependencies and `faiss` (for CPU or for GPU) **Twitter handle:** antonenkodev
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…ctorstore documentation (#18092) **Description:** Refactor code of FAISS vectorcstore and update the related documentation. Details: - replace `.format()` with f-strings for strings formatting; - refactor definition of a filtering function to make code more readable and more flexible; - slightly improve efficiency of `max_marginal_relevance_search_with_score_by_vector` method by removing unnecessary looping over the same elements; - slightly improve efficiency of `delete` method by using set data structure for checking if the element was already deleted; **Issue:** fix small inconsistency in the documentation (the old example was incorrect and unappliable to faiss vectorstore) **Dependencies:** basic langchain-community dependencies and `faiss` (for CPU or for GPU) **Twitter handle:** antonenkodev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Refactor code of FAISS vectorcstore and update the related documentation.
Details:
.format()with f-strings for strings formatting;max_marginal_relevance_search_with_score_by_vectormethod by removing unnecessary looping over the same elements;deletemethod by using set data structure for checking if the element was already deleted;Issue: fix small inconsistency in the documentation (the old example was incorrect and unappliable to faiss vectorstore)
Dependencies: basic langchain-community dependencies and
faiss(for CPU or for GPU)Twitter handle: antonenkodev