Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

langchain_openai[patch]: Invoke callback prior to yielding token #18269

Merged
merged 3 commits into from
Feb 29, 2024
Merged

langchain_openai[patch]: Invoke callback prior to yielding token #18269

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20be62c
Moved on_llm_new_token callback before yield in langchain_openai/llms
williamdevena Feb 28, 2024
cab5f93
x
efriis Feb 28, 2024
7742a9e
Merge branch 'master' into callback_before_yield
efriis Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libs/partners/openai/langchain_openai/llms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def _stream(
if not isinstance(stream_resp, dict):
stream_resp = stream_resp.model_dump()
chunk = _stream_response_to_generation_chunk(stream_resp)
yield chunk

if run_manager:
run_manager.on_llm_new_token(
chunk.text,
Expand All @@ -265,6 +265,7 @@ def _stream(
else None
),
)
yield chunk

async def _astream(
self,
Expand All @@ -281,7 +282,7 @@ async def _astream(
if not isinstance(stream_resp, dict):
stream_resp = stream_resp.model_dump()
chunk = _stream_response_to_generation_chunk(stream_resp)
yield chunk

if run_manager:
await run_manager.on_llm_new_token(
chunk.text,
Expand All @@ -293,6 +294,7 @@ async def _astream(
else None
),
)
yield chunk

def _generate(
self,
Expand Down
Loading