Fix fireworks chat async streaming #18543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:bug
|
cc @benjibc |
|
Oh actually I take it back - this is the deprecated community implementations (on me not Benny for not properly marking these as deprecated). @tjaffri I think you're using a deprecated version of fireworks. Could you switch to the integration package one instead? I'll add the deprecated decorators to this implementation. https://python.langchain.com/docs/integrations/providers/fireworks |
|
OK, moving to the partner package... thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async streaming for fireworks chat seemed to have a typo, fixed in this PR (L259 of fireworks.py)
As part of this, I realized that a lot of integration tests for fireworks were failing... probably not being run regularly? This particular issue was causing one of those tests to fail too and that issue is resolved.
The other tests were failing due to incorrectly expecting stop words to be included in the output as the last char... this is not the right expectation and the tests are now all passing.