-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Implement lazy_load() for MHTMLLoader #18648
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
return [Document(page_content=text, metadata=metadata)] | ||
return [] | ||
yield Document(page_content=text, metadata=metadata) | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do that, the behavior will be slightly different than what exists currently (ie returning only the first part that is text/html
). Is that OK ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my bad I think i didn't notice that this i what it was already doing
…#18648) Covered by `tests/unit_tests/document_loaders/test_mhtml.py`
…#18648) Covered by `tests/unit_tests/document_loaders/test_mhtml.py`
Covered by `tests/unit_tests/document_loaders/test_mhtml.py`
Covered by
tests/unit_tests/document_loaders/test_mhtml.py