Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[minor]: in Document Loader If load() has been overridden, use it in default lazy_load() #18690

Merged
merged 1 commit into from
Mar 7, 2024
Merged

core[minor]: in Document Loader If load() has been overridden, use it in default lazy_load() #18690

merged 1 commit into from
Mar 7, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Mar 6, 2024

No description provided.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 6, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 11:42pm

@dosubot dosubot bot added Ɑ: doc loader Related to document loader module (not documentation) 🔌: anthropic Primarily related to Anthropic integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 6, 2024
@eyurtsev
Copy link
Collaborator

eyurtsev commented Mar 6, 2024

Looks good -- do you want me to comandeer or will you resolve the change?

@eyurtsev eyurtsev self-assigned this Mar 6, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 6, 2024
@cbornet
Copy link
Collaborator Author

cbornet commented Mar 6, 2024

I rebased.
I also moved the test for the doc loader interface from community to core.

@cbornet cbornet force-pushed the lazy-load-fallback branch 2 times, most recently from 25855bc to 2578541 Compare March 6, 2024 23:26
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 7, 2024
@eyurtsev eyurtsev changed the title community: If load() has been overridden, use it in default lazy_load() core[minor]: If load() has been overridden, use it in default lazy_load() Mar 7, 2024
@eyurtsev eyurtsev changed the title core[minor]: If load() has been overridden, use it in default lazy_load() core[minor]: in Document Loader If load() has been overridden, use it in default lazy_load() Mar 7, 2024
@eyurtsev eyurtsev merged commit 4a7d73b into langchain-ai:master Mar 7, 2024
95 checks passed
@cbornet cbornet deleted the lazy-load-fallback branch March 7, 2024 22:20
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
@cbornet
community: If load() has been overridden, use it in default lazy_load…
b4988bb 
…() (langchain-ai#18690)
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@cbornet @gkorland
community: If load() has been overridden, use it in default lazy_load…
a83d281 
…() (langchain-ai#18690)
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@cbornet @hinthornw
community: If load() has been overridden, use it in default lazy_load…
bbd494a 
…() (#18690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees

@eyurtsev eyurtsev

Labels
🔌: anthropic Primarily related to Anthropic integrations Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cbornet @eyurtsev