Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: Chroma use uuid4 instead of uuid1 to generate random ids #18723

Merged
merged 2 commits into from
Mar 7, 2024
Merged

community: Chroma use uuid4 instead of uuid1 to generate random ids #18723

merged 2 commits into from
Mar 7, 2024

Conversation

axiangcoding
Copy link
Contributor

@axiangcoding axiangcoding commented Mar 7, 2024 •
edited

  • Description: Chroma use uuid4 instead of uuid1 as random ids. Use uuid1 may leak mac address, changing to uuid4 will not cause other effects.
  • Issue: None
  • Dependencies: None
  • Twitter handle: None

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 7, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 7:26am

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🔌: chroma Primarily related to ChromaDB integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 7, 2024
@axiangcoding
Copy link
Contributor Author

@baskaryan Really to merge. Please review.

@axiangcoding axiangcoding changed the title community: Chroma use uuid4 instead of uuid1 as random ids community: Chroma use uuid4 instead of uuid1 to generate random ids Mar 7, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 7, 2024
@eyurtsev eyurtsev merged commit 9745b58 into langchain-ai:master Mar 7, 2024
58 checks passed
@eyurtsev
Copy link
Collaborator

eyurtsev commented Mar 7, 2024

Thank you!

bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
@axiangcoding
community[patch]: Chroma use uuid4 instead of uuid1 to generate rando…
50ae411 
…m ids (langchain-ai#18723)

- **Description:** Chroma use uuid4 instead of uuid1 as random ids. Use
uuid1 may leak mac address, changing to uuid4 will not cause other
effects.
  - **Issue:** None
  - **Dependencies:** None
  - **Twitter handle:** None
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@axiangcoding @gkorland
community[patch]: Chroma use uuid4 instead of uuid1 to generate rando…
3baf3a9 
…m ids (langchain-ai#18723)

- **Description:** Chroma use uuid4 instead of uuid1 as random ids. Use
uuid1 may leak mac address, changing to uuid4 will not cause other
effects.
  - **Issue:** None
  - **Dependencies:** None
  - **Twitter handle:** None
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@axiangcoding @hinthornw
community[patch]: Chroma use uuid4 instead of uuid1 to generate rando…
4a871a2 
…m ids (#18723)

- **Description:** Chroma use uuid4 instead of uuid1 as random ids. Use
uuid1 may leak mac address, changing to uuid4 will not cause other
effects.
  - **Issue:** None
  - **Dependencies:** None
  - **Twitter handle:** None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees
No one assigned
Labels
🔌: chroma Primarily related to ChromaDB integrations 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@axiangcoding @eyurtsev