Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat menu item as icon #18806

Merged
merged 1 commit into from
Mar 9, 2024
Merged

chat menu item as icon #18806

merged 1 commit into from
Mar 9, 2024

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented Mar 8, 2024

Controversial and opinionated:
It replaces the "Chat" top-menu item with the 💬 icon.
Reasons:

  • Right part of the top-menu is composed of icons, so, another icon looks organic.
  • "Chat" vs. 💬 It is not 100% clear for both, what they mean. So, parity there.
  • 💬 can be more fun to click
  • 💬 is more compact and more "phone-friendly"
  • 💬 looks good with both themes (Day and Night).

It would be nice to try 💬 for a week and compare its "clickability" with the "Chat".

@vercel Vercel
Copy link

vercel bot commented Mar 8, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 5:11pm

@leo-gan leo-gan marked this pull request as ready for review March 8, 2024 17:55
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 8, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 9, 2024
eyurtsev
eyurtsev reviewed Mar 9, 2024
View reviewed changes
docs/docusaurus.config.js
@@ -254,7 +254,7 @@ const config = {
},
{
href: "https://chat.langchain.com",
label: "Chat",
label: "💬",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there aria-labels?

@eyurtsev eyurtsev merged commit 5d65b47 into langchain-ai:master Mar 9, 2024
11 checks passed
@leo-gan leo-gan deleted the icon-vs-chat branch March 9, 2024 17:59
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
@leo-gan
docs: chat menu item as icon (langchain-ai#18806)
2e0f1a3 
Update chat icon in docs
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@leo-gan @gkorland
docs: chat menu item as icon (langchain-ai#18806)
6aaa789 
Update chat icon in docs
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@leo-gan @hinthornw
docs: chat menu item as icon (#18806)
9aec97d 
Update chat icon in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leo-gan @eyurtsev