community[Qianfan]: re-arrange the addtional_kwargs of returned qianfan structure to avoid _merge_dict issue

[Dobiichi-Origami]

fix issue: #18441
PTAL, thanks
@baskaryan, @efriis, @eyurtsev, @hwchase17.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchain	⬜️ Ignored (Inspect)	Visit Preview		Mar 12, 2024 5:41am

[Dobiichi-Origami]

a new version after fmt has been uploaded, PTAL.
@baskaryan

[yu2tao1]

@Dobiichi-Origami
hi xiongdi, this commit causes the additional_kwargs to lose the function_call information.

1. function_call not in AIMessage:
   

   langchain/libs/community/langchain_community/chat_models/baidu_qianfan_endpoint.py

   Lines 51 to 69 in 9e569d8

   	def _convert_dict_to_message(_dict: Mapping[str, Any]) -> AIMessage:
   	content = _dict.get("result", "") or ""
   	additional_kwargs: Mapping[str, Any] = {}
   	if _dict.get("function_call"):
   	additional_kwargs = {"function_call": dict(_dict["function_call"])}
   	if "thoughts" in additional_kwargs["function_call"]:
   	# align to api sample, which affects the llm function_call output
   	additional_kwargs["function_call"].pop("thoughts")
   	additional_kwargs = {**_dict.get("body", {}), **additional_kwargs}
   	return AIMessage(
   	content=content,
   	additional_kwargs=dict(
   	finish_reason=additional_kwargs.get("finish_reason", ""),
   	request_id=additional_kwargs["id"],
   	object=additional_kwargs.get("object", ""),
   	search_info=additional_kwargs.get("search_info", []),
   	),
   	)

2. but needed at:
   

   langchain/libs/community/langchain_community/chat_models/baidu_qianfan_endpoint.py

   Line 345 in 9e569d8

   additional_kwargs = msg.additional_kwargs.get("function_call", {})

3. funtion_call related code may not work.
   such as in bce-qianfan-sdk:

https://github.com/baidubce/bce-qianfan-sdk/blob/dad3b9b3170007cc5411b2c797ce8646df8df186/python/qianfan/extensions/langchain/agents/baidu_qianfan_endpoint.py#L359-L361

you must be a kind person who can fix this issue.

[sonyfoxcn]

@Dobiichi-Origami hi xiongdi, this commit causes the additional_kwargs to lose the function_call information.

1. function_call not in AIMessage:
   

   langchain/libs/community/langchain_community/chat_models/baidu_qianfan_endpoint.py

   Lines 51 to 69 in 9e569d8

   	def _convert_dict_to_message(_dict: Mapping[str, Any]) -> AIMessage:
   	content = _dict.get("result", "") or ""
   	additional_kwargs: Mapping[str, Any] = {}
   	if _dict.get("function_call"):
   	additional_kwargs = {"function_call": dict(_dict["function_call"])}
   	if "thoughts" in additional_kwargs["function_call"]:
   	# align to api sample, which affects the llm function_call output
   	additional_kwargs["function_call"].pop("thoughts")
   	additional_kwargs = {**_dict.get("body", {}), **additional_kwargs}
   	return AIMessage(
   	content=content,
   	additional_kwargs=dict(
   	finish_reason=additional_kwargs.get("finish_reason", ""),
   	request_id=additional_kwargs["id"],
   	object=additional_kwargs.get("object", ""),
   	search_info=additional_kwargs.get("search_info", []),
   	),
   	)

2. but needed at:
   

   langchain/libs/community/langchain_community/chat_models/baidu_qianfan_endpoint.py

   Line 345 in 9e569d8

   additional_kwargs = msg.additional_kwargs.get("function_call", {})

3. funtion_call related code may not work.
   such as in bce-qianfan-sdk:

https://github.com/baidubce/bce-qianfan-sdk/blob/dad3b9b3170007cc5411b2c797ce8646df8df186/python/qianfan/extensions/langchain/agents/baidu_qianfan_endpoint.py#L359-L361

you must be a kind person who can fix this issue.

Yes, I got the same issue. It's a poor fix.