core[patch]: move some attr/methods to BaseLanguageModel #18936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
efriis
commented
Mar 11, 2024
| """Metadata to add to the run trace.""" | ||
|
|
||
| @validator("verbose", pre=True, always=True) | ||
| def set_verbose(cls, verbose: Optional[bool]) -> bool: |
There was a problem hiding this comment.
was inconsistent before - this used to only be on llms but not chat model. Will now have same behavior for verbose=None for both
| verbose: bool = Field(default_factory=_get_verbosity) | ||
| """Whether to print out response text.""" | ||
| callbacks: Callbacks = Field(default=None, exclude=True) | ||
| """Callbacks to add to the run trace.""" | ||
| callback_manager: Optional[BaseCallbackManager] = Field(default=None, exclude=True) |
There was a problem hiding this comment.
left this in the two places because deprecated and didn't want to add deprecated attr to baselanguagemodel
efriis
changed the title
eyurtsev
approved these changes
Mar 11, 2024
dosubot
bot
added
the
lgtm
bechbd
pushed a commit
to bechbd/langchain
that referenced
this pull request
Mar 29, 2024
…i#18936) Cleans up some shared code between `BaseLLM` and `BaseChatModel`. One functional difference to make it more consistent (see comment)
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…i#18936) Cleans up some shared code between `BaseLLM` and `BaseChatModel`. One functional difference to make it more consistent (see comment)
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
Cleans up some shared code between `BaseLLM` and `BaseChatModel`. One functional difference to make it more consistent (see comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up some shared code between
BaseLLMandBaseChatModel. One functional difference to make it more consistent (see comment)