Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix import path for FlashrankRerank example notebook #19146

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

Simon-Stone
Copy link
Contributor

Description: Fixes the import paths for the FlashrankRerank example notebook.
Issue: #19139
Dependencies: None
Twitter handle: n/a

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:33am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: retriever Related to retriever module 🔌: fireworks Primarily related to Fireworks AI model intergrations 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Mar 15, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why get rid of all the example outputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure how to deal with that. I tend to clear the output of notebooks, because they otherwise always show up in the diff, even though nothing really changes (because the run counter increments and stuff like that). I figured the notebooks might be run as part of the CI/CD pipeline anyway, so I figured I would just clear them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to add the outputs back in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baskaryan I went ahead and added them. This PR is not important (to me) as #19148, so if you only have time to consider one, please check out #19148.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 18, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 19, 2024
@hwchase17 hwchase17 merged commit dc4ce82 into langchain-ai:master Mar 19, 2024
11 checks passed
rahul-trip pushed a commit to daxa-ai/langchain that referenced this pull request Mar 27, 2024
…in-ai#19146)

**Description:** Fixes the import paths for the `FlashrankRerank`
example notebook.
 **Issue:** langchain-ai#19139 
 **Dependencies:** None
 **Twitter handle:** n/a

---------

Co-authored-by: Simon Stone <simon.stone@dartmouth.edu>
Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
…in-ai#19146)

**Description:** Fixes the import paths for the `FlashrankRerank`
example notebook.
 **Issue:** langchain-ai#19139 
 **Dependencies:** None
 **Twitter handle:** n/a

---------

Co-authored-by: Simon Stone <simon.stone@dartmouth.edu>
Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
…in-ai#19146)

**Description:** Fixes the import paths for the `FlashrankRerank`
example notebook.
 **Issue:** langchain-ai#19139 
 **Dependencies:** None
 **Twitter handle:** n/a

---------

Co-authored-by: Simon Stone <simon.stone@dartmouth.edu>
Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
…in-ai#19146)

**Description:** Fixes the import paths for the `FlashrankRerank`
example notebook.
 **Issue:** langchain-ai#19139 
 **Dependencies:** None
 **Twitter handle:** n/a

---------

Co-authored-by: Simon Stone <simon.stone@dartmouth.edu>
Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
…in-ai#19146)

**Description:** Fixes the import paths for the `FlashrankRerank`
example notebook.
 **Issue:** langchain-ai#19139 
 **Dependencies:** None
 **Twitter handle:** n/a

---------

Co-authored-by: Simon Stone <simon.stone@dartmouth.edu>
Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
**Description:** Fixes the import paths for the `FlashrankRerank`
example notebook.
 **Issue:** #19139 
 **Dependencies:** None
 **Twitter handle:** n/a

---------

Co-authored-by: Simon Stone <simon.stone@dartmouth.edu>
Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🔌: fireworks Primarily related to Fireworks AI model intergrations lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: retriever Related to retriever module size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants