-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix import path for FlashrankRerank
example notebook
#19146
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why get rid of all the example outputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure how to deal with that. I tend to clear the output of notebooks, because they otherwise always show up in the diff, even though nothing really changes (because the run counter increments and stuff like that). I figured the notebooks might be run as part of the CI/CD pipeline anyway, so I figured I would just clear them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add the outputs back in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baskaryan I went ahead and added them. This PR is not important (to me) as #19148, so if you only have time to consider one, please check out #19148.
…in-ai#19146) **Description:** Fixes the import paths for the `FlashrankRerank` example notebook. **Issue:** langchain-ai#19139 **Dependencies:** None **Twitter handle:** n/a --------- Co-authored-by: Simon Stone <simon.stone@dartmouth.edu> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
…in-ai#19146) **Description:** Fixes the import paths for the `FlashrankRerank` example notebook. **Issue:** langchain-ai#19139 **Dependencies:** None **Twitter handle:** n/a --------- Co-authored-by: Simon Stone <simon.stone@dartmouth.edu> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
…in-ai#19146) **Description:** Fixes the import paths for the `FlashrankRerank` example notebook. **Issue:** langchain-ai#19139 **Dependencies:** None **Twitter handle:** n/a --------- Co-authored-by: Simon Stone <simon.stone@dartmouth.edu> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
…in-ai#19146) **Description:** Fixes the import paths for the `FlashrankRerank` example notebook. **Issue:** langchain-ai#19139 **Dependencies:** None **Twitter handle:** n/a --------- Co-authored-by: Simon Stone <simon.stone@dartmouth.edu> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
…in-ai#19146) **Description:** Fixes the import paths for the `FlashrankRerank` example notebook. **Issue:** langchain-ai#19139 **Dependencies:** None **Twitter handle:** n/a --------- Co-authored-by: Simon Stone <simon.stone@dartmouth.edu> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
**Description:** Fixes the import paths for the `FlashrankRerank` example notebook. **Issue:** #19139 **Dependencies:** None **Twitter handle:** n/a --------- Co-authored-by: Simon Stone <simon.stone@dartmouth.edu> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
Description: Fixes the import paths for the
FlashrankRerank
example notebook.Issue: #19139
Dependencies: None
Twitter handle: n/a