Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved fake llms and embeddings to core #19226

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

lkuligin
Copy link
Collaborator

  • PR title: "core: moved fake llms and embeddings to core"

  • PR message:

  • Description: moved fake llms and embeddings to core"

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 1:21pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: embeddings Related to text embedding models module 🤖:refactor A large refactor of a feature(s) or restructuring of many files labels Mar 18, 2024
@lkuligin lkuligin force-pushed the fake branch 2 times, most recently from 1bd472a to 8526dca Compare March 18, 2024 13:18
@efriis efriis merged commit 366ba77 into langchain-ai:master Mar 18, 2024
95 checks passed
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 18, 2024
@eyurtsev
Copy link
Collaborator

Are there specific models that are needed for unit tests? langchain_core exposes many fake models right now from core and not all of them are implemented correctly, and most of them are not documented. I think we should be a bit more selective in terms of what's exposed as part of the public API since it's used as reference by developers

rahul-trip pushed a commit to daxa-ai/langchain that referenced this pull request Mar 27, 2024
- [ ] **PR title**: "core: moved fake llms and embeddings to core"


- [ ] **PR message**:
 - **Description:** moved fake llms and embeddings to core"
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
- [ ] **PR title**: "core: moved fake llms and embeddings to core"


- [ ] **PR message**:
 - **Description:** moved fake llms and embeddings to core"
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
- [ ] **PR title**: "core: moved fake llms and embeddings to core"


- [ ] **PR message**:
 - **Description:** moved fake llms and embeddings to core"
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
- [ ] **PR title**: "core: moved fake llms and embeddings to core"


- [ ] **PR message**:
 - **Description:** moved fake llms and embeddings to core"
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
- [ ] **PR title**: "core: moved fake llms and embeddings to core"


- [ ] **PR message**:
 - **Description:** moved fake llms and embeddings to core"
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
- [ ] **PR title**: "core: moved fake llms and embeddings to core"


- [ ] **PR message**:
 - **Description:** moved fake llms and embeddings to core"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:refactor A large refactor of a feature(s) or restructuring of many files size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants