Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: Simplify astream logic in BaseChatModel and BaseLLM #19332

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Mar 20, 2024

Covered by tests in libs/core/tests/unit_tests/language_models/chat_models/test_base.py, libs/core/tests/unit_tests/language_models/llms/test_base.py and libs/core/tests/unit_tests/runnables/test_runnable_events.py

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 0:14am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: core Related to langchain-core 🤖:refactor A large refactor of a feature(s) or restructuring of many files labels Mar 20, 2024
Copy link
Contributor

@maximeperrindev maximeperrindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! I worked on this part few days ago and it's definitely easier to understand now

@eyurtsev eyurtsev self-assigned this Mar 20, 2024
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this is much cleaner

@eyurtsev eyurtsev merged commit 4c2e887 into langchain-ai:master Mar 20, 2024
95 checks passed
@eyurtsev eyurtsev changed the title core: Simplify astream logic in BaseChatModel and BaseLLM core[patch]: Simplify astream logic in BaseChatModel and BaseLLM Mar 20, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 20, 2024
@cbornet cbornet deleted the models-astream branch March 20, 2024 14:06
rahul-trip pushed a commit to daxa-ai/langchain that referenced this pull request Mar 27, 2024
…ai#19332)

Covered by tests in
`libs/core/tests/unit_tests/language_models/chat_models/test_base.py`,
`libs/core/tests/unit_tests/language_models/llms/test_base.py` and
`libs/core/tests/unit_tests/runnables/test_runnable_events.py`
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
…ai#19332)

Covered by tests in
`libs/core/tests/unit_tests/language_models/chat_models/test_base.py`,
`libs/core/tests/unit_tests/language_models/llms/test_base.py` and
`libs/core/tests/unit_tests/runnables/test_runnable_events.py`
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
…ai#19332)

Covered by tests in
`libs/core/tests/unit_tests/language_models/chat_models/test_base.py`,
`libs/core/tests/unit_tests/language_models/llms/test_base.py` and
`libs/core/tests/unit_tests/runnables/test_runnable_events.py`
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
…ai#19332)

Covered by tests in
`libs/core/tests/unit_tests/language_models/chat_models/test_base.py`,
`libs/core/tests/unit_tests/language_models/llms/test_base.py` and
`libs/core/tests/unit_tests/runnables/test_runnable_events.py`
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
…ai#19332)

Covered by tests in
`libs/core/tests/unit_tests/language_models/chat_models/test_base.py`,
`libs/core/tests/unit_tests/language_models/llms/test_base.py` and
`libs/core/tests/unit_tests/runnables/test_runnable_events.py`
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
Covered by tests in
`libs/core/tests/unit_tests/language_models/chat_models/test_base.py`,
`libs/core/tests/unit_tests/language_models/llms/test_base.py` and
`libs/core/tests/unit_tests/runnables/test_runnable_events.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:refactor A large refactor of a feature(s) or restructuring of many files size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants