langchain_cohere: Add Cohere multi hop agent #19650

BeatrixCohere · 2024-03-27T11:56:06Z

Description: Adds the experimental version of multi-hop agent as a raw prompt

vercel · 2024-03-27T11:56:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchain	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 29, 2024 8:30pm

libs/partners/cohere/docs/multi_hop_agent.ipynb

libs/partners/cohere/langchain_cohere/multi_hop/agent.py

…chain into beatrix/MultiHopAgent

minjie-cohere

Nice work 👏
Left some comments and suggestions re. more thoroughly addressing issues 4 & 5 identified by Patrick. Please fix 🫡

minjie-cohere · 2024-03-30T14:09:11Z

libs/partners/cohere/langchain_cohere/cohere_agent.py

+                    description=param_definition.get("description")
+                    if "description" in param_definition
+                    else "",


Suggested change

description=param_definition.get("description")

if "description" in param_definition

else "",

description=param_definition.get("description") or ""

to avoid rendering param description as None (issue 5)? we should apply the same fix to the other cases as well

minjie-cohere · 2024-03-30T15:11:29Z

libs/partners/cohere/langchain_cohere/react_multi_hop/agent.py

+def get_type(type_: str, is_optional: bool) -> str:
+    python_type = JSON_TO_PYTHON_TYPES.get(type_, type_)


The following will get us List[str] (or List[int], ...) instead of array, which addresses a popular and important case.

Suggested change

def get_type(type_: str, is_optional: bool) -> str:

python_type = JSON_TO_PYTHON_TYPES.get(type_, type_)

# https://json-schema.org/understanding-json-schema/reference/type

JSON_SCHEMA_TO_PYTHON_TYPES = {

"string": "str",

"number": "float",

"boolean": "bool",

"integer": "int",

"array": "List",

"object": "Dict",

}

def get_type(json_schema_type: Union[str, dict], is_optional: bool) -> str:

if json_schema_type == "object":

python_type = "Dict"

elif json_schema_type == "array":

item_type = JSON_SCHEMA_TO_PYTHON_TYPES.get(json_schema_type["items"]["type"], "")

python_type = f"List[{item_type}]" if item_type else "List"

else:

python_type = JSON_SCHEMA_TO_PYTHON_TYPES.get(json_schema_type) or str(json_schema_type)

minjie-cohere · 2024-03-30T15:16:22Z

libs/partners/cohere/langchain_cohere/react_multi_hop/agent.py

+        type_ = get_type(
+            parameter_definition.get("type"), "default" in parameter_definition
+        )
+        description = parameter_definition.get("description")


Suggested change

description = parameter_definition.get("description")

description = parameter_definition.get("description") or ""

to avoid rendering None into param description

minjie-cohere · 2024-03-30T15:20:34Z

libs/partners/cohere/langchain_cohere/cohere_agent.py

+                    description=param_definition.get("description")
+                    if "description" in param_definition
+                    else "",
+                    type=JSON_TO_PYTHON_TYPES.get(


reuse get_type from libs/partners/cohere/langchain_cohere/react_multi_hop/agent.py for consistency

minjie-cohere · 2024-03-30T15:22:19Z

libs/partners/cohere/langchain_cohere/cohere_agent.py

@@ -11,7 +11,12 @@
 from langchain_core.runnables import Runnable, RunnablePassthrough
 from langchain_core.runnables.base import RunnableLambda
 from langchain_core.tools import BaseTool
-from langchain_core.utils.function_calling import convert_to_openai_function
+from langchain_core.utils.function_calling import (
+    PYTHON_TO_JSON_TYPES,


this only handles primitive types (i.e. not array and object). see below for a more complete solution.

minjie-cohere · 2024-03-30T15:22:41Z

libs/partners/cohere/langchain_cohere/cohere_agent.py

@@ -101,7 +110,9 @@ def _convert_to_cohere_tool(
            parameter_definitions={
                param_name: ToolParameterDefinitionsValue(
                    description=param_definition.get("description"),


minjie-cohere · 2024-03-30T15:22:50Z

libs/partners/cohere/langchain_cohere/cohere_agent.py

@@ -121,7 +132,9 @@ def _convert_to_cohere_tool(
            parameter_definitions={
                param_name: ToolParameterDefinitionsValue(
                    description=param_definition.get("description"),


minjie-cohere · 2024-03-30T15:23:00Z

libs/partners/cohere/langchain_cohere/cohere_agent.py

+                    type=JSON_TO_PYTHON_TYPES.get(
+                        param_definition.get("type"), param_definition.get("type")
+                    ),


minjie-cohere · 2024-03-30T15:23:15Z

libs/partners/cohere/langchain_cohere/cohere_agent.py

+                    type=JSON_TO_PYTHON_TYPES.get(
+                        param_definition.get("type"), param_definition.get("type")
+                    ),


harry-cohere · 2024-04-02T14:55:46Z

Thanks Minjie and Beatrix (and Erick for the review so far). We've reopened this PR in:

#19919

**Description**: Adds an agent that uses Cohere with multiple hops and multiple tools. This PR is a continuation of #19650 - which was previously approved. Conceptually nothing has changed, but this PR has extra fixes, documentation and testing. --------- Co-authored-by: BeatrixCohere <128378696+BeatrixCohere@users.noreply.github.com> Co-authored-by: Erick Friis <erickfriis@gmail.com>

**Description**: Adds an agent that uses Cohere with multiple hops and multiple tools. This PR is a continuation of langchain-ai/langchain#19650 - which was previously approved. Conceptually nothing has changed, but this PR has extra fixes, documentation and testing. --------- Co-authored-by: BeatrixCohere <128378696+BeatrixCohere@users.noreply.github.com> Co-authored-by: Erick Friis <erickfriis@gmail.com>

**Description**: Adds an agent that uses Cohere with multiple hops and multiple tools. This PR is a continuation of #19650 - which was previously approved. Conceptually nothing has changed, but this PR has extra fixes, documentation and testing. --------- Co-authored-by: BeatrixCohere <128378696+BeatrixCohere@users.noreply.github.com> Co-authored-by: Erick Friis <erickfriis@gmail.com>

BeatrixCohere added 4 commits March 26, 2024 11:35

implement multihop agent

7914525

remove

c047868

Update prompt

8b0c86a

Remove new line

157fcd0

efriis added the partner label Mar 27, 2024

efriis self-assigned this Mar 27, 2024

dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 27, 2024

dosubot bot added Ɑ: agent Related to agents module 🔌: cohere Primarily related to Cohere integrations 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Mar 27, 2024

BeatrixCohere added 5 commits March 27, 2024 11:59

Fix notebok

db7be4d

Lint

6853755

Spelling

bb4762d

Fix test

768dd37

Merge conflicts

eeb46f1

pat-cohere reviewed Mar 28, 2024

View reviewed changes

libs/partners/cohere/docs/multi_hop_agent.ipynb Show resolved Hide resolved

BeatrixCohere added 2 commits March 28, 2024 16:07

Add chat history

a549a11

Fix prompt

068549b

efriis reviewed Mar 28, 2024

View reviewed changes

libs/partners/cohere/langchain_cohere/multi_hop/agent.py Outdated Show resolved Hide resolved

Update libs/partners/cohere/langchain_cohere/multi_hop/agent.py

4bde450

efriis approved these changes Mar 28, 2024

View reviewed changes

dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 28, 2024

BeatrixCohere added 6 commits March 28, 2024 19:08

Remove new lines

fc98316

Merge branch 'beatrix/MultiHopAgent' of github.com:BeatrixCohere/lang…

e705454

…chain into beatrix/MultiHopAgent

Update the naming and notebook

74b55e3

Test

fed0bad

Add premable override

e00a3f1

Fix text repsonse

a9e6a4a

dosubot bot removed the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 29, 2024

dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 29, 2024

BeatrixCohere added 2 commits March 29, 2024 15:21

Format

e3cf615

Delete

a24ffc3

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 29, 2024

vercel bot deployed to Preview March 29, 2024 15:37 View deployment

Fix formatting

59c8c39

vercel bot deployed to Preview March 29, 2024 15:56 View deployment

harry-cohere added 2 commits March 29, 2024 17:09

Increase default timeout

e46b382

Fix stop sequences

c31c157

vercel bot deployed to Preview March 29, 2024 17:36 View deployment

harry-cohere added 2 commits March 29, 2024 18:26

convert parameter types

b3b9d3f

add resilience to action parsing

ec58586

vercel bot deployed to Preview March 29, 2024 18:37 View deployment

harry-cohere added 3 commits March 29, 2024 19:13

prompt rendering changes

403f78a

prompt rendering changes

8f8d8f0

fix types

a6f445d

vercel bot deployed to Preview March 29, 2024 19:35 View deployment

don't nest prompt function

610d9c4

vercel bot deployed to Preview March 29, 2024 20:30 View deployment

minjie-cohere suggested changes Mar 30, 2024

View reviewed changes

This was referenced Apr 2, 2024

cohere: Add multi hop agent cohere-ai/langchain#118

Closed

Cohere: Add multihop tool agent #19919

Merged

BeatrixCohere closed this Apr 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

langchain_cohere: Add Cohere multi hop agent #19650

langchain_cohere: Add Cohere multi hop agent #19650

BeatrixCohere commented Mar 27, 2024

vercel bot commented Mar 27, 2024 •

edited

minjie-cohere left a comment

minjie-cohere Mar 30, 2024

minjie-cohere Mar 30, 2024

minjie-cohere Mar 30, 2024

minjie-cohere Mar 30, 2024

minjie-cohere Mar 30, 2024

minjie-cohere Mar 30, 2024

minjie-cohere Mar 30, 2024

minjie-cohere Mar 30, 2024

minjie-cohere Mar 30, 2024

harry-cohere commented Apr 2, 2024

		def get_type(type_: str, is_optional: bool) -> str:
		python_type = JSON_TO_PYTHON_TYPES.get(type_, type_)

-def get_type(type_: str, is_optional: bool) -> str:
-    python_type = JSON_TO_PYTHON_TYPES.get(type_, type_)
+# https://json-schema.org/understanding-json-schema/reference/type
+JSON_SCHEMA_TO_PYTHON_TYPES = {
+    "string": "str",
+    "number": "float",
+    "boolean": "bool",
+    "integer": "int",
+    "array": "List",
+    "object": "Dict",
+}
+def get_type(json_schema_type: Union[str, dict], is_optional: bool) -> str:
+    if json_schema_type == "object":
+        python_type = "Dict"
+    elif json_schema_type == "array":
+        item_type = JSON_SCHEMA_TO_PYTHON_TYPES.get(json_schema_type["items"]["type"], "")
+        python_type = f"List[{item_type}]" if item_type else "List"
+    else:
+        python_type = JSON_SCHEMA_TO_PYTHON_TYPES.get(json_schema_type) or str(json_schema_type)

	description = parameter_definition.get("description")
	description = parameter_definition.get("description") or ""

langchain_cohere: Add Cohere multi hop agent #19650

langchain_cohere: Add Cohere multi hop agent #19650

Conversation

BeatrixCohere commented Mar 27, 2024

vercel bot commented Mar 27, 2024 • edited

minjie-cohere left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harry-cohere commented Apr 2, 2024

vercel bot commented Mar 27, 2024 •

edited