New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Request Body containing Reference : OpenAPI functions #19751
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@baskaryan @efriis Can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a unit test for this change?
@baskaryan I had updated the PR with unit tests cases. Also I have tried to add more description here in PR, will add details in linked issue also. Request you to kindly review the PR. |
@baskaryan @efriis Please review this PR |
@baskaryan @dosubot I need small help with this PR. Looks like build was failing due to lint and test failure. I had pushed changes for lint but I am unable to identify solution for test failure which is failing due to module missing. Please let me know whom can I reach out for help? Looks like my build is failing due to module not found "openapi-pydantic" in following test class https://github.com/anujmehta/langchain/blob/request-body-reference/libs/community/tests/unit_tests/utilities/test_openapi.py. I am unable to find solution for it as the dependency is already present at https://github.com/anujmehta/langchain/blob/request-body-reference/libs/community/pyproject.toml#L22 and is added to extended_testing https://github.com/anujmehta/langchain/blob/request-body-reference/libs/community/pyproject.toml#L244. |
@baskaryan @efriis @hwchase17 Gentle reminder. Can you please help me with above query? |
@olgavrou @agola11 @3coins @sjwhitmore I see your valuable contribution to Langchain. Can you please help me in resolving this minor issue so that I can merge the PR? |
Thank you for contributing to LangChain!
PR title: "package: description"
PR message: Delete this entire checklist and replace with
-In below screenshot we have a complex payload and this PR tries to handle schema of "address" and "hobbies" attributes as shown below
.
make format
,make lint
andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.