core: bind_tools interface on basechatmodel #20360
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
| *, | ||
| tool_choice: Optional[ | ||
| Union[Dict, str, Literal["auto", "any", "none"], bool] | ||
| ] = None, |
There was a problem hiding this comment.
also game to leave this explicit kwarg off. But feels like we'll start recommending it for models that support it and wouldn't want re-use in another way.
There was a problem hiding this comment.
don't think tool_choice should be on base implementation, anthropic doesn't support
There was a problem hiding this comment.
But it won't fail them because it's an optional kwarg.
What it will fail is someone defining bind_tools(..., tool_choice: int)
Thoughts on keeping?
There was a problem hiding this comment.
imo weird to have it as part of signature on implementations that don't support it. also feels like a still pretty beta feature for most providers. also seems easier to add later if things change than to try to remove if things change. but don't feel super strongly here
There was a problem hiding this comment.
removed. Can add later easily.
No description provided.