Using the right encoding to parse the web page in RecursiveUrlLoader #20632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
baskaryan
approved these changes
Apr 19, 2024
dosubot
bot
added
the
lgtm
eyurtsev
reviewed
Apr 19, 2024
libs/community/langchain_community/document_loaders/recursive_url_loader.py
Outdated
Show resolved
Hide resolved
dosubot
bot
added
size:S
eyurtsev
approved these changes
Apr 25, 2024
| @@ -169,6 +178,12 @@ def _get_child_links_recursive( | |||
| visited.add(url) | |||
| try: | |||
| response = requests.get(url, timeout=self.timeout, headers=self.headers) | |||
|
|
|||
| if self.encoding is not None: | |||
There was a problem hiding this comment.
This looks reasonable to me. Might be better not do it by mutating the response encoding
Instead modifying the code below to do
encoding = ...
text = response.content.decode(encoding=encoding)There was a problem hiding this comment.
response.text actually do what you said, and this is the current way to use the response in RecursiveUrlLoader
In
response.text, it decodes response.content by
content = str(self.content, encoding, errors="replace")
return contentIt's just like your text = response.content.decode(encoding=encoding)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in #13749 ,
RecursiveUrlLoaderhas encoding issue. This PR is to solve this.