community: Add support for Upstash Vector #20824
Conversation
Head branch was pushed to by a user without write access
|
Thanks for the review @baskaryan! Should we resolve all the failing CI checks to merge this PR or are we waiting for review/approval from other people? I didn't try to resolve all CI issues because we want to offer some functionality on top of what is possible with the VectorStore interface (like embeddings). Since you approved the PR I am not making further changes |
Resolving CI failures would be great! |
I had included nest_asyncio.apply in the test to stop an error I was getting: "RuntimeError: asyncio.run() cannot be called from a running event loop" But nest_asyncio couldn't be imported in CI so I had to remove it. To fix the error, I had to downgrade vcrpy to 4.3.0 and urllib3 to 1.26.18 according to poetry.lock. This solved the error I was getting. This also meant that the cassettes changed. Updating them aswell.
|
Hi again @baskaryan, CI errors are resolved. Used VCR to record the integration tests aswell! |
|
Hi @baskaryan, It looks like all tests pass except Vercel deployment, which got |
Description
Adding
UpstashVectorStoreto utilize Upstash Vector!#17012 was opened to add Upstash Vector to langchain but was closed to wait for filtering. Now filtering is added to Upstash vector and we open a new PR. Additionally, embedding feature was added and we add this to our vectorstore aswell.
Dependencies
upstash-vector should be installed to use
UpstashVectorStore. Didn't update dependencies because of this comment in the previous PR.Tests
Tests are added and they pass. Tests are naturally network bound since Upstash Vector is offered through an API.
There was a discussion in the previous PR about mocking the unittests. We didn't make changes to this end yet. We can update the tests if you can explain how the tests should be mocked.