-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: add materialized view support for SQLDatabase #20954
Open
juanjzunino
wants to merge
11
commits into
langchain-ai:master
Choose a base branch
from
juanjzunino:jjz/add-materialized-view
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
community: add materialized view support for SQLDatabase #20954
juanjzunino
wants to merge
11
commits into
langchain-ai:master
from
juanjzunino:jjz/add-materialized-view
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjzunino
commented
Apr 26, 2024
- Description: add materialized view support for SQLDatabase
- Issue: Materialized Views not accessible #4349
- Dependencies: None
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Apr 26, 2024
dosubot
bot
added
the
🤖:improvement
Medium size change to existing code to handle new use-cases
label
Apr 26, 2024
i believe this is new in sqlalchemy 0.2, which means if using with sqlaclehmy before 0.2 (whcih we support) this would break. any ideas on how to handle? could include some check on sqlalchemy version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:improvement
Medium size change to existing code to handle new use-cases
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.