Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced ConversationSummaryBufferMemory with Asynchronous Capability #20956

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

meikethomas
Copy link

Added asynchronously callable methods according to the ConversationSummaryBufferMemory API documentation.

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2024 0:29am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: memory Related to memory module 🤖:improvement Medium size change to existing code to handle new use-cases labels Apr 26, 2024
@@ -18,6 +18,35 @@ class ConversationSummaryBufferMemory(BaseChatMemory, SummarizerMixin):
def buffer(self) -> List[BaseMessage]:
return self.chat_memory.messages

async def abuffer(self) -> Any:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this match typing/functionality of buffer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases Ɑ: memory Related to memory module size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants