New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[add] upsert texts to the Milvus vectorstore #20976
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@baskaryan Please review |
@ccurme Can you please review this as well. upsert same thing which provided in add_text method Thanks |
@rgupta2508 can you clarify, are these two equivalent? milvus.upsert_texts(texts, metadatas=metadatas) and from langchain_core.documents import Document
documents = [Document(text, metadata=metadata) for text, metadata in zip(texts, metadatas)]
milvus.upsert(documents=documents) i.e., is this a convenience method, or is there missing functionality? |
Ohh got it, thanks for clarification. Closing this PR |
Upsert texts to the Milvus vectorstore.
This is based on upsert data based on add_text functionality
In case metadata need to upsert in milvus,
Metadata keys will need to be present for all inserted values. At
the moment there is no None equivalent in Milvus.