Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add] upsert texts to the Milvus vectorstore #20976

Closed
wants to merge 11 commits into from

Conversation

rgupta2508
Copy link
Contributor

Upsert texts to the Milvus vectorstore.
This is based on upsert data based on add_text functionality
In case metadata need to upsert in milvus,
Metadata keys will need to be present for all inserted values. At
the moment there is no None equivalent in Milvus.

Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2024 9:54am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🔌: milvus Primarily related to Milvus vector store integration 🤖:improvement Medium size change to existing code to handle new use-cases labels Apr 27, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 28, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 28, 2024
@rgupta2508
Copy link
Contributor Author

@baskaryan Please review

@rgupta2508
Copy link
Contributor Author

@ccurme Can you please review this as well.

upsert same thing which provided in add_text method

Thanks

@ccurme
Copy link
Collaborator

ccurme commented May 7, 2024

@rgupta2508 can you clarify, are these two equivalent?

milvus.upsert_texts(texts, metadatas=metadatas)

and

from langchain_core.documents import Document

documents = [Document(text, metadata=metadata) for text, metadata in zip(texts, metadatas)]
milvus.upsert(documents=documents)

i.e., is this a convenience method, or is there missing functionality?

@rgupta2508
Copy link
Contributor Author

@rgupta2508 can you clarify, are these two equivalent?

milvus.upsert_texts(texts, metadatas=metadatas)

and

from langchain_core.documents import Document

documents = [Document(text, metadata=metadata) for text, metadata in zip(texts, metadatas)]
milvus.upsert(documents=documents)

i.e., is this a convenience method, or is there missing functionality?

Ohh got it, thanks for clarification.

Closing this PR

@rgupta2508 rgupta2508 closed this May 9, 2024
@rgupta2508 rgupta2508 deleted the milvus_upsert_text branch May 15, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases 🔌: milvus Primarily related to Milvus vector store integration size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants