[Community] : Added SentenceWindowRetriever #20981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated TextSplitter to include a new add_chunk_id to add a chunk_id variable into document metadata
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: text splitters
Updated chunk_id logic to persist chunk_id across different pages of the same source text
|
@eyurtsev @baskaryan This metadata variable is a prerequisite for setting up the new implementation of the Sentence Window Retrieval method. |
|
@hwchase17 @efriis Can i get a review on this? |
dosubot
bot
added
size:L
rsk2327
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
Description : Updated TextSplitter to include a new add_chunk_id argument to add a chunk_id variable into document metadata
This is a prerequisite for implementing the Sentence Window Retriever broadly across all databases as it helps easily identify neighboring chunks of text from the same text source
Add tests and docs
This is a simple argument addition thats False by default and has basic logic. Specific unit tests might not be necessary
Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified.If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.