partners[openai]: add tests for secret_str for keys #20982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:L
ccurme
reviewed
Apr 29, 2024
| monkeypatch.setenv("AZURE_OPENAI_API_KEY", "secret-api-key") | ||
| monkeypatch.setenv("AZURE_OPENAI_AD_TOKEN", "secret-ad-token") | ||
| chat_model = AzureChatOpenAI( | ||
| openai_api_key="secret-api-key", |
There was a problem hiding this comment.
Should we remove the secrets from the constructor in this case, to enforce that they're read from the env vars?
There was a problem hiding this comment.
Yes. I was a tad too aggressive with the copy-paste.
| # azure openai | ||
| def test_azure_openai_api_key_is_secret_string() -> None: | ||
| """Test that the API key is stored as a SecretStr.""" | ||
| llm = AzureOpenAI( |
There was a problem hiding this comment.
(nit) Are we able to parametrize these at all? e.g.,
from typing import Type
import pytest
@pytest.mark.parametrize(
"model_class", [AzureChatOpenAI, AzureOpenAI, AzureOpenAIEmbeddings]
)
def test_api_key_is_secret_string(model_class: Type) -> None:
model_instance = model_class(
openai_api_key="secret-api-key",
azure_endpoint="endpoint",
azure_ad_token="secret-ad-token",
api_version="version",
)
assert isinstance(model_instance.openai_api_key, SecretStr)
...There was a problem hiding this comment.
Yes. Thank you - I'd overlooked this simplification.
baskaryan
approved these changes
May 1, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add tests to check API keys and Active Directory tokens are masked
Issue: Resolves #12165 for OpenAI and Azure OpenAI models
Dependencies: None
Also resolves #12473 which may be closed.
Additional contributors @alex4321 (#12473) and @onesolpark (#12542)