community: import fix #20995
Merged
community: import fix #20995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
baskaryan
approved these changes
Apr 29, 2024
dosubot
bot
added
the
lgtm
|
@baskaryan Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When the third-party package is not installed, whenever we need to
pip install <package>the ImportError is raised.But sometimes, the
ValueErrororModuleNotFoundErroris raised. It is bad for consistency.Change: replaced the
ValueErrororModuleNotFoundErrorwithImportErrorwhen we raise an error with thepip install <package>message.Note: Ideally, we replace all
try: import... except... raise ...with helper functions likeimport_aimor just use the existing langchain_core.utils.utils.guard_import But it would be much bigger refactoring. @baskaryan Please, advice on this.