Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 1 missing line in getting_started.md #2107

Merged
merged 3 commits into from Mar 28, 2023

Conversation

AlexTelon
Copy link
Contributor

Seems like a copy paste error. The very next example does have this line.

Please tell me if I missed something in the process and should have created an issue or something first!

@AlexTelon
Copy link
Contributor Author

Was missing an import for this as well. Again similar to the next example. I just missed adding it here. Sorry for that.

I'm noticing some unused imports around here as well. Notably AIMessagePromptTemplate ok to remove those here or should I create a separate PR for that? For me it is fine either way.

@hwchase17
Copy link
Contributor

Was missing an import for this as well. Again similar to the next example. I just missed adding it here. Sorry for that.

I'm noticing some unused imports around here as well. Notably AIMessagePromptTemplate ok to remove those here or should I create a separate PR for that? For me it is fine either way.

okay to remove here

thanks for that!

@hwchase17 hwchase17 merged commit ef25904 into langchain-ai:master Mar 28, 2023
9 checks passed
@AlexTelon AlexTelon deleted the missing_line_in_docs branch March 29, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants