Harrison/unstructured validation #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `headers` parameters for UnstructuredURLLoader.
If the version of `unstructured` is less than 0.5.7 and `headers` is not
an empty dict, the user will see a warning (You are using old version of
unstructured. The headers parameter is ignored).
Ways to reproduce:
```bash
poetry add unstructured="0.5.6"
```
```python
from langchain.document_loaders import UnstructuredURLLoader
urls = [
"https://www.understandingwar.org/backgrounder/russian-offensive-campaign-assessment-february-8-2023",
"https://doesnotexistithinkprobablynotverynotlikely.io",
"https://www.understandingwar.org/backgrounder/russian-offensive-campaign-assessment-february-9-2023",
]
loader = UnstructuredURLLoader(urls=urls, continue_on_failure=False, headers={"User-Agent": "value"})
```
Logs:
```
You are using old version of unstructured. The headers parameter is ignored
```
In this case, headers will not be passed to `partition_html` function.
If the user will create the object of `UnstructuredURLLoader` without
the `headers` parameter or with an empty dict, he will not see the
warning.
If the unstructured version is equal to or more than 0.5.7, the user
will not see the warning after creating the object of
`UnstructuredURLLoader` with the `headers` parameter.
---
Closes issue #1944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.