Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix RetrievalQA Docs: docs: Fix formatting #21183

Merged
merged 3 commits into from
May 3, 2024

Conversation

TAAGECH9
Copy link
Contributor

@TAAGECH9 TAAGECH9 commented May 2, 2024

Newline Characters breaking formatting

Description:
As you can see in the image below, the formatting in the documentation is broken. As far as I can see the two added \n characters are breaking the documentation. Therefore I would propose to remove those
image

Dependencies:
None

Twitter Handle

  • epu9byj

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 2, 2024
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 0:43am

@dosubot dosubot bot added Ɑ: retriever Related to retriever module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels May 2, 2024
@TAAGECH9 TAAGECH9 changed the title **Hotfix RetrievalQA Docs**: docs: Fix formatting Hotfix RetrievalQA Docs: docs: Fix formatting May 2, 2024
@ccurme
Copy link
Collaborator

ccurme commented May 3, 2024

Great catch thanks.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 3, 2024
@ccurme ccurme enabled auto-merge (squash) May 3, 2024 12:44
@ccurme ccurme merged commit 3a8d1d8 into langchain-ai:master May 3, 2024
42 checks passed
raspawar pushed a commit to raspawar/langchain that referenced this pull request May 3, 2024
# Newline Characters breaking formatting 

**Description**: 
As you can see in the image below, the formatting in the documentation
is broken. As far as I can see the two added `\n` characters are
breaking the documentation. Therefore I would propose to remove those

![image](https://github.com/langchain-ai/langchain/assets/88305668/23b6e726-71b2-4812-91ea-3e8600683733)

**Dependencies**:
None

**Twitter Handle**
- epu9byj

---------

Co-authored-by: gere <gere@kapo.zh.ch>
Co-authored-by: Chester Curme <chester.curme@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: retriever Related to retriever module size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants