Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain: summarize chain fix #21266

Merged
merged 1 commit into from
May 3, 2024

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented May 3, 2024

Issue: load_summarize_chain is placed in the init.py file. As a result, it doesn't listed in the API Reference docs.
Change: moved code from init.py into a new file.

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 6:20pm

@leo-gan leo-gan marked this pull request as ready for review May 3, 2024 18:27
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 3, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 3, 2024
@ccurme ccurme merged commit 23a05c3 into langchain-ai:master May 3, 2024
42 checks passed
@leo-gan
Copy link
Collaborator Author

leo-gan commented May 3, 2024

@ccurme Thanks!

@leo-gan leo-gan deleted the langchain-summarize-fix branch May 3, 2024 21:10
This was referenced May 3, 2024
ccurme pushed a commit that referenced this pull request May 6, 2024
Issue: `load_qa_chain` is placed in the __init__.py file. As a result,
it is not listed in the API Reference docs.
BTW `load_qa_chain` is heavily presented in the doc examples, but is
missed in API Ref.
Change: moved code from init.py into a new file. Related: #21266
dglogo pushed a commit to dglogo/langchain that referenced this pull request May 8, 2024
Issue: `load_qa_chain` is placed in the __init__.py file. As a result,
it is not listed in the API Reference docs.
BTW `load_qa_chain` is heavily presented in the doc examples, but is
missed in API Ref.
Change: moved code from init.py into a new file. Related: langchain-ai#21266
kyle-cassidy pushed a commit to kyle-cassidy/langchain that referenced this pull request May 10, 2024
Issue: `load_qa_chain` is placed in the __init__.py file. As a result,
it is not listed in the API Reference docs.
BTW `load_qa_chain` is heavily presented in the doc examples, but is
missed in API Ref.
Change: moved code from init.py into a new file. Related: langchain-ai#21266
kyle-cassidy pushed a commit to kyle-cassidy/langchain that referenced this pull request May 16, 2024
Issue: `load_qa_chain` is placed in the __init__.py file. As a result,
it is not listed in the API Reference docs.
BTW `load_qa_chain` is heavily presented in the doc examples, but is
missed in API Ref.
Change: moved code from init.py into a new file. Related: langchain-ai#21266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants