-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Dockerfile to run unit tests in a Docker container #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergerdn
changed the title
feat: add Dockerfile to run tests in a Docker container
feat: add Dockerfile to run unit tests in a Docker container
Mar 30, 2023
This makes it easy to run the tests locally. Some tests may not be able to run in Windows environments, hence the need for a Dockerfile. The new Dockerfile sets up a multi-stage build to install Poetry and dependencies, and then copies the project code to a final image for tests. The Makefile has been updated to include a new 'docker_tests' target that builds the Docker image and runs the tests inside a container.
Any comments would be appreciated. Take a look #2174
|
hwchase17
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easy to run the tests locally. Some tests may not be able to run in
Windows
environments, hence the need for aDockerfile
.The new
Dockerfile
sets up a multi-stage build to install Poetry and dependencies, and then copies the project code to a final image for tests.The
Makefile
has been updated to include a new 'docker_tests' target that builds the Docker image and runs theunit tests
inside a container.It would be beneficial to offer a local testing environment for developers by enabling them to run a Docker image on their local machines with the required dependencies, particularly for integration tests. While this is not included in the current PR, it would be straightforward to add in the future.
This pull request lacks documentation of the changes made at this moment.