Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli[minor]: add astradb in the cli migration to 0.2 #21913

Merged
merged 1 commit into from
May 20, 2024

Conversation

nicoloboschi
Copy link
Contributor

astradb has a new partner package but the automatic migration cli tool doesn't take care of migration astradb integrations

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 0:30am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🔌: astradb Primarily related to AstraDB integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels May 20, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 20, 2024
@eyurtsev eyurtsev changed the title partners: add astradb in the cli migration to 0.2 cli[minor]: add astradb in the cli migration to 0.2 May 20, 2024
@eyurtsev eyurtsev merged commit dd00aac into langchain-ai:master May 20, 2024
11 checks passed
@hemidactylus
Copy link
Contributor

Too late now, but shouldn't the two lines

langchain_community.cache.astradb.AstraDBCache
langchain_community.cache.astradb.AstraDBSemanticCache

actually be:

langchain_community.cache.AstraDBCache
langchain_community.cache.AstraDBSemanticCache

@nicoloboschi nicoloboschi deleted the migrate-astra branch May 20, 2024 15:58
eyurtsev pushed a commit that referenced this pull request May 20, 2024
… json data (#21926)

This PR fixes two mistakes in the import paths from community for the
json data aiding the cli migration to 0.2.

It is intended as a quick follow-up to
#21913 .

@nicoloboschi FYI
jeromechoo pushed a commit to jeromechoo/langchain that referenced this pull request May 20, 2024
astradb has a new partner package but the automatic migration cli tool
doesn't take care of migration astradb integrations
jeromechoo pushed a commit to jeromechoo/langchain that referenced this pull request May 20, 2024
… json data (langchain-ai#21926)

This PR fixes two mistakes in the import paths from community for the
json data aiding the cli migration to 0.2.

It is intended as a quick follow-up to
langchain-ai#21913 .

@nicoloboschi FYI
JuHyung-Son pushed a commit to JuHyung-Son/langchain that referenced this pull request May 23, 2024
astradb has a new partner package but the automatic migration cli tool
doesn't take care of migration astradb integrations
JuHyung-Son pushed a commit to JuHyung-Son/langchain that referenced this pull request May 23, 2024
… json data (langchain-ai#21926)

This PR fixes two mistakes in the import paths from community for the
json data aiding the cli migration to 0.2.

It is intended as a quick follow-up to
langchain-ai#21913 .

@nicoloboschi FYI
hinthornw pushed a commit that referenced this pull request Jun 20, 2024
astradb has a new partner package but the automatic migration cli tool
doesn't take care of migration astradb integrations
hinthornw pushed a commit that referenced this pull request Jun 20, 2024
… json data (#21926)

This PR fixes two mistakes in the import paths from community for the
json data aiding the cli migration to 0.2.

It is intended as a quick follow-up to
#21913 .

@nicoloboschi FYI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌: astradb Primarily related to AstraDB integrations 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants