community: Add async methods to CassandraChatMessageHistory #21975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
eyurtsev
reviewed
May 21, 2024
| def __init__( | ||
| self, | ||
| session_id: str, | ||
| session: Optional[Session] = None, | ||
| keyspace: Optional[str] = None, | ||
| table_name: str = DEFAULT_TABLE_NAME, | ||
| ttl_seconds: Optional[int] = DEFAULT_TTL_SECONDS, | ||
| *, | ||
| setup_mode: Optional[SetupMode] = SetupMode.SYNC, |
There was a problem hiding this comment.
What's your perspective on setup_mode vs. having a dedicated async_session ?
There was a problem hiding this comment.
The cassandra Session is used for both sync and async so there's no "async session"
cbornet
force-pushed
the
async-CassandraChatMessageHistory
branch
from
9fd6551
to
ed41313
Compare
hinthornw
pushed a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.