Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Pinecone tab to "How to create and query vector stores" #22076

Closed
wants to merge 8 commits into from

Conversation

junefish
Copy link
Contributor

@junefish junefish commented May 23, 2024

Thank you for contributing to LangChain!

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.


Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 6:44pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 23, 2024
@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🔌: pinecone Primarily related to Pinecone vector store integration 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels May 23, 2024
@junefish
Copy link
Contributor Author

junefish commented May 23, 2024

ETA: Vercel deployed a new version and it looks correct

In the Vercel preview, the Markdown is not displaying correctly. I'm not sure whether this is an issue with the deployment, but it displays correctly in the VS Code preview.
Screenshot 2024-05-23 at 1 55 58 PM

@junefish
Copy link
Contributor Author

@efriis for review please


</TabItem>
<TabItem value="pinecone" label="Pinecone">

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the current vectorstores features here are local vectorstores if I'm not mistaken. We did this on purpose to avoid a race between vectorstores providing to populate the tabs on this page. cc @efriis

@efriis
Copy link
Member

efriis commented May 24, 2024

Closing because Pinecone doesn't fit into this list of open source + local offerings! Will be featured in the vectorstore index list when we redo that.

@efriis efriis closed this May 24, 2024
@junefish junefish deleted the vectorstore-howto branch June 17, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🔌: pinecone Primarily related to Pinecone vector store integration size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants