Harrison/sql alchemy #2216
Merged
Harrison/sql alchemy #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent filtering of tables (#1841) The current wrapper class for SQLAlchemy is inconsistent in its usage of 'include_tables' and 'ignore_tables' class properties. This pull request is meant to create a distinct function (get_usable_tables) so as to prevent the usage of tables which have been specifically excluded when the class is instantiated. All function calls in the SQLDatabase base class and related tools have been ported to use new function. This implementation still allows using the SQLAlchemy standard way to get all tables which exist in the database by using the original function get_all_tables(). This is my first pull request, so feedback is appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.