Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip unit tests that fails in Windows #2238

Merged
merged 1 commit into from
Apr 1, 2023
Merged

skip unit tests that fails in Windows #2238

merged 1 commit into from
Apr 1, 2023

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented Mar 31, 2023 •
edited

closes #2174
Several unit tests fail in Windows.
Added pytest attribute to skip these tests automatically.

@leo-gan leo-gan mentioned this pull request Mar 31, 2023
Closed
hwchase17
hwchase17 approved these changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit 579ad85 into langchain-ai:master Apr 1, 2023
9 checks passed
@leo-gan leo-gan deleted the skip_win_ut_in_linux branch April 18, 2023 03:38
@leo-gan leo-gan changed the title skip unit tests that fail in Windows skip unit tests that fails in Windows Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed tests on Windows platform
2 participants
@leo-gan @hwchase17