pinecone: Fix multiprocessing issue in PineconeVectorStore #22571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
efriis
approved these changes
Jun 6, 2024
dosubot
bot
added
the
lgtm
|
@efriis could you please review this? |
|
@efriis any updates on this? |
|
Hey @efriis could you please review this PR and make the necessary approvals? |
|
@efriis could you please review the changes and update the PR? |
|
@efriis could you please have a look at this PR? |
|
@efriis Any updates on this? |
efriis
approved these changes
Jun 21, 2024
…store-multiprocessing
|
Thanks 🙏 @efriis |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, the
langchain_pineconelibrary forces theasync_req(asynchronous required) argument to Pinecone toTrue. This design choice causes problems when deploying to environments that do not support multiprocessing, such as AWS Lambda. In such environments, this restriction can prevent users from successfully usinglangchain_pinecone.This PR introduces a change that allows users to specify whether they want to use asynchronous requests by passing the
async_reqparameter through**kwargs. By doing so, users can setasync_req=Falseto utilize synchronous processing, making the library compatible with AWS Lambda and other environments that do not support multithreading.Issue:
This PR does not address a specific issue number but aims to resolve compatibility issues with AWS Lambda by allowing synchronous processing.
Dependencies:
None, that I'm aware of.