core[patch]: Correctly order parent ids in astream events (from root to immediate parent), add defensive check for cycles #22637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
eyurtsev
changed the title
eyurtsev
commented
Jun 6, 2024
| @@ -118,13 +118,20 @@ def __init__( | |||
| def _get_parent_ids(self, run_id: UUID) -> List[str]: | |||
| """Get the parent IDs of a run (non-recursively) cast to strings.""" | |||
| parent_ids = [] | |||
There was a problem hiding this comment.
list of parents ids isn't big so using list instead of deque
nfcampos
approved these changes
Jun 6, 2024
dosubot
bot
added
the
lgtm
JonZeolla
pushed a commit
to JonZeolla/langchain
that referenced
this pull request
Jun 11, 2024
…to immediate parent), add defensive check for cycles (langchain-ai#22637) This PR makes two changes: 1. Fixes the order of parent IDs to be from root to immediate parent 2. Adds a simple defensive check for cycles
hinthornw
pushed a commit
that referenced
this pull request
Jun 20, 2024
…to immediate parent), add defensive check for cycles (#22637) This PR makes two changes: 1. Fixes the order of parent IDs to be from root to immediate parent 2. Adds a simple defensive check for cycles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes: