langchain[minor]: Add native async implementation to LLMFilter, add concurrency to both sync and async paths #22739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
eyurtsev
requested changes
Jun 10, 2024
libs/langchain/langchain/retrievers/document_compressors/chain_filter.py
Outdated
Show resolved
Hide resolved
libs/langchain/langchain/retrievers/document_compressors/chain_filter.py
Outdated
Show resolved
Hide resolved
|
@pprados if you're able try to use [patch], [minor], [major] in the PR message it makes it easier to see where a review is required + we'll be using it in change logs down the road (This looks like [minor] to me rather than a bug fix since it's adding a native async implementation.) |
eyurtsev
changed the title
eyurtsev
changed the title
eyurtsev
changed the title
**Description:**: Update MongoDB information in llm_caching
langchain-ai#22707) **Description:** Scheduled GitHub Actions to run only on the upstream repository **Issue:** Fixes langchain-ai#22706 **Twitter handle:** @coolbeevip
…elf query retriever (langchain-ai#22678) The fact that we outsourced pgvector to another project has an unintended effect. The mapping dictionary found by `_get_builtin_translator()` cannot recognize the new version of pgvector because it comes from another package. `SelfQueryRetriever` no longer knows `PGVector`. I propose to fix this by creating a global dictionary that can be populated by various database implementations. Thus, importing `langchain_postgres` will allow the registration of the `PGvector` mapping. But for the moment I'm just adding a lazy import Furthermore, the implementation of _get_builtin_translator() reconstructs the BUILTIN_TRANSLATORS variable with each invocation, which is not very efficient. A global map would be an optimization. - **Twitter handle:** pprados @eyurtsev, can you review this PR? And unlock the PR [Add async mode for pgvector](langchain-ai/langchain-postgres#32) and PR [community[minor]: Add SQL storage implementation](langchain-ai#22207)? Are you in favour of a global dictionary-based implementation of Translator?
Signed-off-by: zhangwangda <zhangwangda94@163.com>
Hi 👋 First off, thanks a ton for your work on this 💚 Really appreciate what you're providing here for the community. ## Description This PR adds a basic language parser for the [Elixir](https://elixir-lang.org/) programming language. The parser code is based upon the approach outlined in langchain-ai#13318: it's using `tree-sitter` under the hood and aligns with all the other `tree-sitter` based parses added that PR. The `CHUNK_QUERY` I'm using here is probably not the most sophisticated one, but it worked for my application. It's a starting point to provide "core" parsing support for Elixir in LangChain. It enables people to use the language parser out in real world applications which may then lead to further tweaking of the queries. I consider this PR just the ground work. - **Dependencies:** requires `tree-sitter` and `tree-sitter-languages` from the extended dependencies - **Twitter handle:**`@bitcrowd` ## Checklist - [x] **PR title**: "package: description" - [x] **Add tests and docs** - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. <!-- If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17. -->
dosubot
bot
added
size:L
dosubot
bot
added
size:M
|
@eyurtsev |
eyurtsev
reviewed
Jun 11, 2024
| _input = self.get_input(query, doc) | ||
| output_dict = self.llm_chain.invoke(_input, config={"callbacks": callbacks}) | ||
|
|
||
| config = RunnableConfig(callbacks=callbacks) |
There was a problem hiding this comment.
Might be worthwhile to update the docs to say that this runs without a limit on the max concurrency. This could lead to issues for some users that will be difficult to debug.
We'll need to make a change here to expose config in the signature instead of callbacks, but that's not for this PR
eyurtsev
approved these changes
Jun 11, 2024
dosubot
bot
added
the
lgtm
hinthornw
pushed a commit
that referenced
this pull request
Jun 20, 2024
…oncurrency to both sync and async paths (#22739) Thank you for contributing to LangChain! - [ ] **PR title**: "langchain: Fix chain_filter.py to be compatible with async" - [ ] **PR message**: - **Description:** chain_filter is not compatible with async. - **Twitter handle:** pprados - [X ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ --------- Signed-off-by: zhangwangda <zhangwangda94@163.com> Co-authored-by: Prakul <discover.prakul@gmail.com> Co-authored-by: Lei Zhang <zhanglei@apache.org> Co-authored-by: Gin <ictgtvt@gmail.com> Co-authored-by: wangda <38549158+daziz@users.noreply.github.com> Co-authored-by: Max Mulatz <klappradla@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
PR title: "langchain: Fix chain_filter.py to be compatible with async"
PR message:
[X ] Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/