core[patch]: set schema format for AsyncRootListenersTracer #23214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mackong
commented
Jun 20, 2024
mackong
commented
- Description: AsyncRootListenersTracer support on_chat_model_start, it's schema_format should be "original+chat".
- Issue: N/A
- Dependencies:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:XS
eyurtsev
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
@nicolasnk any concerns with this change? I think we want to merge this in, but wanted to check in with you first.
dosubot
bot
added
the
lgtm
|
@mackong thanks, going to give @nicolasnk a chance to opine prior to merging in |
Hey @eyurtsev. Thanks for letting me know. I see that the same code for RootListener. Does it make sense to do it in the parent class _TracerCore ? |
|
@nicolasnk Yes, but we'll do it as a part of a separate PR. We need to spec out if anything might break for users that are sub-classing from BaseTracer right now |
lalanikarim
pushed a commit
to lalanikarim/langchain
that referenced
this pull request
Jun 23, 2024
…n-ai#23214) - **Description:** AsyncRootListenersTracer support on_chat_model_start, it's schema_format should be "original+chat". - **Issue:** N/A - **Dependencies:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.