Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: elasticsearch #2402

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix: elasticsearch #2402

merged 1 commit into from
Apr 5, 2023

Conversation

sergerdn
Copy link
Contributor

@sergerdn sergerdn commented Apr 4, 2023

  • Create a new docker-compose file to start an Elasticsearch instance for integration tests.
  • Add new tests to test_elasticsearch.py to verify Elasticsearch functionality.
  • Include an optional group test_integration in the pyproject.toml file. This group should contain dependencies for integration tests and can be installed using the command poetry install --with test_integration. Any new dependencies should be added by running poetry add some_new_deps --group "test_integration"

Note:
New tests running in live mode, which involve end-to-end testing of the OpenAI API. In the future, adding pytest-vcr to record and replay all API requests would be a nice feature for testing process.More info: https://pytest-vcr.readthedocs.io/en/latest/

Fixes #2386

@sergerdn sergerdn marked this pull request as ready for review April 4, 2023 23:51
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, thanks!!

@hwchase17 hwchase17 merged commit b410dc7 into langchain-ai:master Apr 5, 2023
9 checks passed
@sergerdn sergerdn deleted the fix/elasticsearch branch April 5, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vectorstores error: "search_phase_execution_exceptionm" after using elastic search
2 participants