Add custom vector fields and text fields for OpenSearch #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
add_custom_vector_fields
branch
from
26c3d42
to
28816be
Compare
vowelparrot
approved these changes
Apr 11, 2023
| _validate_embeddings_and_bulk_size(len(embeddings), bulk_size) | ||
| vector_field = _get_kwargs_value(kwargs, "vector_field", "vector_field") |
There was a problem hiding this comment.
This is a meta-comment on a previous PR, but _get_kwargs_value could just be kwargs.get(key, default_value)
There was a problem hiding this comment.
@vowelparrot there is a PR addressing this #13184
|
how to define same using langchain javascript opensearchvectorstore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add custom vector field name and text field name while indexing and querying for OpenSearch
Issues
#2500