Comet updates #2889
Merged
Comet updates #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make sure all required dependencies are installed. * Make sure that the dependencies are installed with the Python interpreter of the current kernel. * Change the way to set environment variables to make it more fool-proof.
CometCallbackHandler will now creates a new Experiment every time it's created or every time `flush_tracker` is called with `reset=True`. This behavior should be less surprising.
dev2049
reviewed
Apr 14, 2023
| @@ -34,12 +34,10 @@ def _get_experiment( | |||
| ) -> Any: | |||
| comet_ml = import_comet_ml() | |||
|
|
|||
| experiment = comet_ml.config.get_global_experiment() | |||
There was a problem hiding this comment.
The current behavior is to re-use a Comet Experiment if one was created before and if not create a new one.
That behavior can be confusing for users that creates multiple instance of CometCallbackHandler and can leads to subtle bugs where the new Experiment is in the wrong workspace or project_name.
So we decided to get with a more simpler approach, one instance of CometCallbackHandler equals one instance of Comet Experiment.
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
I'm working with @DN6 and I made some small fixes and improvements after playing with the integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm working with @DN6 and I made some small fixes and improvements after playing with the integration.